Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/opencode/src/session/prompt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export namespace SessionPrompt {
},
async (current) => {
for (const item of Object.values(current)) {
item.callbacks = []
item.abort.abort()
}
},
Expand Down Expand Up @@ -261,6 +262,14 @@ export namespace SessionPrompt {
SessionStatus.set(sessionID, { type: "idle" })
return
}

const error = new Error("Session cancelled")
const queued = match.callbacks
match.callbacks = []
for (const q of queued) {
q.reject(error)
}

match.abort.abort()
delete s[sessionID]
SessionStatus.set(sessionID, { type: "idle" })
Expand Down Expand Up @@ -714,7 +723,9 @@ export namespace SessionPrompt {
SessionCompaction.prune({ sessionID })
for await (const item of MessageV2.stream(sessionID)) {
if (item.info.role === "user") continue
const queued = state()[sessionID]?.callbacks ?? []
const match = state()[sessionID]
const queued = match?.callbacks ?? []
if (match) match.callbacks = []
for (const q of queued) {
q.resolve(item)
}
Expand Down
58 changes: 58 additions & 0 deletions packages/opencode/test/session/prompt-cancel.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { describe, expect, test } from "bun:test"
import { Instance } from "../../src/project/instance"
import { Session } from "../../src/session"
import { SessionPrompt } from "../../src/session/prompt"
import { Log } from "../../src/util/log"
import { tmpdir } from "../fixture/fixture"

Log.init({ print: false })

describe("session.prompt cancel", () => {
test("rejects queued loop callbacks", async () => {
await using tmp = await tmpdir({
git: true,
config: {
agent: {
build: {
model: "openai/gpt-5.2",
},
},
},
})

await Instance.provide({
directory: tmp.path,
fn: async () => {
const session = await Session.create({})

const command = process.platform === "win32" ? "ping -n 6 127.0.0.1 >nul" : "sleep 5"

const running = SessionPrompt.shell({
sessionID: session.id,
agent: "build",
command,
})
void running.catch(() => {})

const queued = SessionPrompt.loop({ sessionID: session.id })
SessionPrompt.cancel(session.id)

const result = await Promise.race([
queued.then(
() => ({ type: "resolved" as const }),
(error) => ({ type: "rejected" as const, error }),
),
Bun.sleep(200).then(() => ({ type: "timeout" as const })),
])

expect(result.type).toBe("rejected")
if (result.type === "rejected") {
expect(result.error).toBeInstanceOf(Error)
expect((result.error as Error).message).toBe("Session cancelled")
}

await Session.remove(session.id)
},
})
})
})
Loading