WIP: Add support for remote Parquet HDFS writer with openDAL #2929
+643
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
============================================
+ Coverage 56.12% 59.59% +3.46%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15494 +3751
Branches 2251 2570 +319
============================================
+ Hits 6591 9233 +2642
- Misses 4012 4961 +949
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I can see double writes in the plan now |
This was referenced Dec 23, 2025
comphead
force-pushed
the
opendal_writes
branch
from
e2dfaa1 to
cc21ac4
Compare
Contributor
Author
|
Filed #2971 for double writes |
comphead
force-pushed
the
opendal_writes
branch
from
cc21ac4 to
27c4d54
Compare
comphead
changed the title
comphead
requested review from
andygrove,
mbutrovich,
parthchandra and
wForget
comphead
commented
Dec 24, 2025
| fn parse_hdfs_url(url: &Url) -> Result<(Box<dyn ObjectStore>, Path), object_store::Error> { | ||
| // Creates an HDFS object store from a URL using the native HDFS implementation | ||
| #[cfg(all(feature = "hdfs", not(feature = "hdfs-opendal")))] | ||
| fn create_hdfs_object_store( |
Contributor
Author
There was a problem hiding this comment.
renamed from parse_hdfs_url to reflect more sense
wForget
reviewed
Dec 25, 2025
| if (!cmd.outputPath.toString.startsWith("file:")) { | ||
| return Unsupported(Some("Only local filesystem output paths are supported")) | ||
| if (!cmd.outputPath.toString.startsWith("file:") && !cmd.outputPath.toString | ||
| .startsWith("hdfs:")) { |
wForget
reviewed
Dec 25, 2025
| sync::Arc, | ||
| }; | ||
|
|
||
| use opendal::{services::Hdfs, Operator}; |
Member
There was a problem hiding this comment.
Is hdfs-opendal always enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Running experiments to use openDAL with HDFS writes on local and remote clusters
Closes #2890 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?