Fix query_timeout validation to use AnalysisException#60558
Open
plchy2 wants to merge 1 commit intoapache:masterfrom
Open
Fix query_timeout validation to use AnalysisException#60558plchy2 wants to merge 1 commit intoapache:masterfrom
plchy2 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem was fixed?
The session variable query_timeout validation currently throws UnsupportedOperationException
for invalid values. This is inconsistent with other FE validations and results in unclear
error handling for invalid user input.
Additionally, non-numeric values could cause an unhandled NumberFormatException.
How was it fixed?
Replaced UnsupportedOperationException with AnalysisException
Added explicit number format validation for query_timeout
Improved error messages for invalid values
Behavior changes
Before
Invalid query_timeout values threw UnsupportedOperationException
Non-numeric values could cause unclear runtime exceptions
After
Invalid values throw AnalysisException
Non-numeric input is handled gracefully with clear error messages
Impact
This change improves consistency of session variable validation and provides clearer
feedback to users without affecting existing valid configurations.