Skip to content

Fix query_timeout validation to use AnalysisException #60558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plchy2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix query_timeout validation to use AnalysisException #60558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4841,17 +4841,22 @@ public boolean isDropTableIfCtasFailed() {
return dropTableIfCtasFailed;
}

public void checkQueryTimeoutValid(String newQueryTimeout) {
int value = Integer.valueOf(newQueryTimeout);
if (value <= 0) {
UnsupportedOperationException exception =
new UnsupportedOperationException(
"query_timeout can not be set to " + newQueryTimeout + ", it must be greater than 0");
LOG.warn("Check query_timeout failed", exception);
throw exception;
}
public void checkQueryTimeoutValid(String newQueryTimeout) throws AnalysisException {
int value;
try {
value = Integer.parseInt(newQueryTimeout);
} catch (NumberFormatException e) {
throw new AnalysisException(
"query_timeout must be a positive integer, but got: " + newQueryTimeout);
}

if (value <= 0) {
throw new AnalysisException(
"query_timeout must be greater than 0, but got: " + newQueryTimeout);
}
}


public void checkMaxExecutionTimeMSValid(String newValue) {
int value = Integer.valueOf(newValue);
if (value < 1000) {
Expand Down