fix: raise precise exception in rest_catalog list_namespaces #1977
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandro-nori
force-pushed
the
fix_no_ns_exception_rest
branch
from
2f56a35 to
461a9d7
Compare
Fokko
approved these changes
May 7, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
I fully agree @alessandro-nori! 🙌 Thanks for fixing this
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
…1977) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change `list_namespaces` should raise a `NoSuchNamespaceException` instead of a generic `RestException` in case of a 404 response. https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L279-L287 Also this is in line with the Java implementation of [NamespaceErrorHandler](https://github.com/apache/iceberg/blob/9fb80b7167e58a2daef80f4a1a09f223b870c030/core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java#L182) used by `[listNamespaces()](https://github.com/apache/iceberg/blob/9fb80b7167e58a2daef80f4a1a09f223b870c030/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L584)` # Are these changes tested? I added a unit test for it # Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
list_namespacesshould raise aNoSuchNamespaceExceptioninstead of a genericRestExceptionin case of a 404 response.https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L279-L287
Also this is in line with the Java implementation of NamespaceErrorHandler used by
[listNamespaces()](https://github.com/apache/iceberg/blob/9fb80b7167e58a2daef80f4a1a09f223b870c030/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L584)Are these changes tested?
I added a unit test for it
Are there any user-facing changes?