Add deprecation message for source-id #2098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1547
Rationale for this change
Iceberg v3 does not support
source-idand only supportssource-ids. Meanwhile, Iceberg v2 only supportssource-id.Right now, it appears that all versions of Iceberg support both
source-idandsource-ids.This PR does what #1547 asks and deprecates
source-id. It seems like the most proper thing to do would be to make these fields aware of the Iceberg format version and then error out accordingly. But, I wanted to get everyone's opinion before I go down that path.