Skip to content

Add deprecation message for source-id #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rambleraptor wants to merge 1 commit into from
Closed

Add deprecation message for source-id #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pyiceberg/partitioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
UUIDType,
)
from pyiceberg.utils.datetime import date_to_days, datetime_to_micros, time_to_micros
from pyiceberg.utils.deprecated import deprecation_message

INITIAL_PARTITION_SPEC_ID = 0
PARTITION_FIELD_ID_START: int = 1000
Expand Down Expand Up @@ -101,6 +102,13 @@ def __init__(
if name is not None:
data["name"] = name

if data["source-id"]:
deprecation_message(
deprecated_in="0.10.0",
removed_in="0.11.0",
help_message="source-id is not allowed for Iceberg v3. Please use source-ids instead.",
)

super().__init__(**data)

@model_validator(mode="before")
Expand Down
9 changes: 9 additions & 0 deletions pyiceberg/table/sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from pyiceberg.transforms import IdentityTransform, Transform, parse_transform
from pyiceberg.typedef import IcebergBaseModel
from pyiceberg.types import IcebergType
from pyiceberg.utils.deprecated import deprecation_message


class SortDirection(Enum):
Expand Down Expand Up @@ -85,6 +86,14 @@ def __init__(
data["direction"] = direction
if null_order is not None:
data["null-order"] = null_order

if data["source-id"]:
deprecation_message(
deprecated_in="0.10.0",
removed_in="0.11.0",
help_message="source-id is not allowed for Iceberg v3. Please use source-ids instead.",
)

super().__init__(**data)

@model_validator(mode="before")
Expand Down
Loading