Improve Docs for IRC Catalog Connection #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Jul 6, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for adding this! Much needed. I added a few comments. Please take a look
kevinjqliu
reviewed
Jul 8, 2025
Contributor
There was a problem hiding this comment.
Thank you @james5418. I think we're almost there! Lets group the OAuth options together and split out SigV4 as a separate AWS specific auth option
kevinjqliu
reviewed
Jul 8, 2025
kevinjqliu
approved these changes
Jul 8, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
This looks great! LGTM!
Contributor
|
Thanks for the contribution @james5418 :) |
Fokko
pushed a commit
that referenced
this pull request
Jul 8, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
[`ugi` is a Hive Catalog
property](https://github.com/apache/iceberg-python/blob/e33cf5ac1adf47131d4992bdb686f0e58f4e4669/pyiceberg/catalog/hive.py#L322-L327).
It was accidentally added to the REST catalog section in
5209874#diff-497e037708cc64870c6ba9372f6064a69ca1e74d65d6195dcee5a44851e8b47dR151
#2175 removed it from the REST catalog section.
This PR adds `ugi` back to the Hive Catalog section
<img width="666" alt="Screenshot 2025-07-08 at 7 48 41 AM"
src="https://github.com/user-attachments/assets/42247bae-4dfd-4688-b4d5-a33bd94d686b"
/>
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Closes apache#2096
Included examples and detailed configuration guidance to enhance
clarity.
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
[`ugi` is a Hive Catalog
property](https://github.com/apache/iceberg-python/blob/e33cf5ac1adf47131d4992bdb686f0e58f4e4669/pyiceberg/catalog/hive.py#L322-L327).
It was accidentally added to the REST catalog section in
apache@5209874#diff-497e037708cc64870c6ba9372f6064a69ca1e74d65d6195dcee5a44851e8b47dR151
apache#2175 removed it from the REST catalog section.
This PR adds `ugi` back to the Hive Catalog section
<img width="666" alt="Screenshot 2025-07-08 at 7 48 41 AM"
src="https://github.com/user-attachments/assets/42247bae-4dfd-4688-b4d5-a33bd94d686b"
/>
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #2096
Included examples and detailed configuration guidance to enhance clarity.
Are these changes tested?
Are there any user-facing changes?