Nit: Make DataScan::_check_sequence_number static
#2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
commented
Jul 10, 2025
Comment on lines
+1860
to
+1861
| @staticmethod | ||
| def _check_sequence_number(min_sequence_number: int, manifest: ManifestFile) -> bool: |
Contributor
Author
There was a problem hiding this comment.
Silencing PyCharm warning that DataScan::_check_sequence_number can be static. Could have alternatively lifted the method out of the class. Not strongly opinionated between the two
kevinjqliu
approved these changes
Jul 10, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
this is also only used once in the same file, so i think its fine to leave it as is
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Silence PyCharm warning that `DataScan::_check_sequence_number` can be
static.
# Are these changes tested?
N/A
# Are there any user-facing changes?
No
<!-- In the case of user-facing changes, please add the changelog label.
-->
Co-authored-by: Sreesh Maheshwar <smaheshwar@palantir.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Silence PyCharm warning that
DataScan::_check_sequence_numbercan be static.Are these changes tested?
N/A
Are there any user-facing changes?
No