Skip to content

Nit: Make DataScan::_check_sequence_number static #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Jul 10, 2025
Merged

Nit: Make DataScan::_check_sequence_number static #2196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,8 @@ def _build_residual_evaluator(self, spec_id: int) -> Callable[[DataFile], Residu
)
)

def _check_sequence_number(self, min_sequence_number: int, manifest: ManifestFile) -> bool:
@staticmethod
def _check_sequence_number(min_sequence_number: int, manifest: ManifestFile) -> bool:
Comment on lines +1860 to +1861
Copy link
Contributor Author

@smaheshwar-pltr smaheshwar-pltr Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silencing PyCharm warning that DataScan::_check_sequence_number can be static. Could have alternatively lifted the method out of the class. Not strongly opinionated between the two

"""Ensure that no manifests are loaded that contain deletes that are older than the data.

Args:
Expand Down