Skip to content

Nit: Clean up comments in DataScan::_build_residual_evaluator #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Jul 10, 2025
Merged

Nit: Clean up comments in DataScan::_build_residual_evaluator #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,13 +1841,11 @@ def _build_metrics_evaluator(self) -> Callable[[DataFile], bool]:
def _build_residual_evaluator(self, spec_id: int) -> Callable[[DataFile], ResidualEvaluator]:
spec = self.table_metadata.specs()[spec_id]

from pyiceberg.expressions.visitors import residual_evaluator_of

# The lambda created here is run in multiple threads.
# So we avoid creating _EvaluatorExpression methods bound to a single
# shared instance across multiple threads.
# return lambda data_file: (partition_schema, partition_expr, self.case_sensitive)(data_file.partition)
from pyiceberg.expressions.visitors import residual_evaluator_of

# assert self.row_filter == False
return lambda datafile: (
residual_evaluator_of(
spec=spec,
Expand Down