Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Aug 22, 2025

Rationale for this change

Minor quality of life changes to release docs

  • Added a copy button to script lines
Screenshot 2025-08-22 at 12 15 46 PM
  • Apache PyIceberg -> PyIceberg. "Apache PyIceberg" sounds like a top-level, standalone project. I prefer we use use just "PyIceberg"

Are these changes tested?

Are there any user-facing changes?


```sh
svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-${PYICEBERG_VERSION}/ ${PYICEBERG_VERIFICATION_DIR}
svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-$PYICEBERG_VERSION/ ${PYICEBERG_VERIFICATION_DIR}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously ${PYICEBERG_VERSION} would expand to $\{PYICEBERG_VERSION\}/ in iterm and mess up the url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught me several times!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, but no more!

@kevinjqliu kevinjqliu requested a review from Fokko August 22, 2025 19:18
@kevinjqliu kevinjqliu requested a review from Fokko August 27, 2025 18:42
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @kevinjqliu 🙌

@Fokko Fokko merged commit 3c7c279 into apache:main Aug 28, 2025
10 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/improve-release branch August 28, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants