[Upstream Error] Pin pydantic version <2.12.0 to avoid regression #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athossampayo
approved these changes
Oct 7, 2025
gabeiglio
approved these changes
Oct 7, 2025
kevinjqliu
approved these changes
Oct 7, 2025
Contributor
Contributor
|
Great catch @HonahX 🙌 |
Fokko
added a commit
to Fokko/iceberg-rust
that referenced
this pull request
Oct 10, 2025
Got fixed upstream apache/iceberg-python#2591
liurenjie1024
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Oct 10, 2025
## Which issue does this PR close? Got fixed upstream apache/iceberg-python#2591 - Closes #1736 . ## What changes are included in this PR? ## Are these changes tested?
This was referenced Oct 19, 2025
Fokko
pushed a commit
that referenced
this pull request
Oct 20, 2025
…ydantic 2.12.3 (#2635) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Follow up to #2591 Closes #2590 Pydantic released a regression in 2.12.x that was fixed by 2.12.2 and 2.12.3 2.12.2 originally did not work due to incompatible signature that was fixed in #2626 2.12.3 turn the incompatible signature into a deprecation warning. This PR disallows pydantic 2.12.0 and 2.12.1 and update poetry lock to use pydantic 2.12.3 With #2626 merged, pyiceberg should work with both pydantic 2.12.2 and 2.12.3 ## Are these changes tested? Yes, UT. Tested both with pydantic 2.12.2 and 2.12.3 ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. --> No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #2590
I seem to be faster than the dependabot : ).
Pin pydantic version to
<2.12.0to avoid the recent regression: pydantic/pydantic#12347.I made this an upper bound because it is unclear about the fix plan in pydantic community. Once their fix is out, we could release the upper bound and exclude affected versions only
Are these changes tested?
No dependency version update. Tested the new version in #2589 and confirmed the regression
Are there any user-facing changes?
No
cc: @Fokko @kevinjqliu