Skip to content

GH-2891: Include actual values in validation error messages and improve logging #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 1 commit into from
Sep 24, 2025
Merged

GH-2891: Include actual values in validation error messages and improve logging #3319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions parquet-column/src/main/java/org/apache/parquet/schema/Types.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ protected Builder(Class<P> returnClass) {
protected abstract THIS self();

protected final THIS repetition(Type.Repetition repetition) {
Preconditions.checkArgument(!repetitionAlreadySet, "Repetition has already been set");
Preconditions.checkArgument(
!repetitionAlreadySet, "Repetition has already been set to: %s", this.repetition);
this.repetition = Objects.requireNonNull(repetition, "Repetition cannot be null");
this.repetitionAlreadySet = true;
return self();
Expand Down Expand Up @@ -656,20 +657,27 @@ protected DecimalMetadata decimalMetadata() {
if (scaleAlreadySet) {
Preconditions.checkArgument(
this.scale == decimalType.getScale(),
"Decimal scale should match with the scale of the logical type");
"Decimal scale should match with the scale of the logical type. Expected: %s, but was: %s",
decimalType.getScale(),
this.scale);
}
if (precisionAlreadySet) {
Preconditions.checkArgument(
this.precision == decimalType.getPrecision(),
"Decimal precision should match with the precision of the logical type");
"Decimal precision should match with the precision of the logical type. Expected: %s, but was: %s",
decimalType.getPrecision(),
this.precision);
}
scale = decimalType.getScale();
precision = decimalType.getPrecision();
}
Preconditions.checkArgument(precision > 0, "Invalid DECIMAL precision: %s", precision);
Preconditions.checkArgument(this.scale >= 0, "Invalid DECIMAL scale: %s", this.scale);
Preconditions.checkArgument(
this.scale <= precision, "Invalid DECIMAL scale: cannot be greater than precision");
this.scale <= precision,
"Invalid DECIMAL scale: %s cannot be greater than precision: %s",
this.scale,
precision);
meta = new DecimalMetadata(precision, scale);
}
return meta;
Expand Down Expand Up @@ -1115,12 +1123,18 @@ protected ListValueBuilder<MP, M> self() {
}

protected void setKeyType(Type keyType) {
Preconditions.checkState(this.keyType == null, "Only one key type can be built with a MapBuilder");
Preconditions.checkState(
this.keyType == null,
"Only one key type can be built with a MapBuilder, but found existing type: %s",
this.keyType);
this.keyType = keyType;
}

protected void setValueType(Type valueType) {
Preconditions.checkState(this.valueType == null, "Only one key type can be built with a ValueBuilder");
Preconditions.checkState(
this.valueType == null,
"Only one value type can be built with a ValueBuilder, but found existing type: %s",
this.valueType);
this.valueType = valueType;
}

Expand Down Expand Up @@ -1207,7 +1221,9 @@ public THIS value(Type type) {
@Override
protected Type build(String name) {
Preconditions.checkState(
logicalTypeAnnotation == null, "MAP is already a logical type and can't be changed.");
logicalTypeAnnotation == null,
"MAP is already a logical type and can't be changed. Current annotation: %s",
logicalTypeAnnotation);
if (keyType == null) {
keyType = STRING_KEY;
}
Expand Down Expand Up @@ -1260,7 +1276,10 @@ public BaseListBuilder(Class<P> returnType) {
}

public THIS setElementType(Type elementType) {
Preconditions.checkState(this.elementType == null, "Only one element can be built with a ListBuilder");
Preconditions.checkState(
this.elementType == null,
"Only one element can be built with a ListBuilder, but found existing type: %s",
this.elementType);
this.elementType = elementType;
return self();
}
Expand Down Expand Up @@ -1357,7 +1376,9 @@ public LP named(String name) {
@Override
protected Type build(String name) {
Preconditions.checkState(
logicalTypeAnnotation == null, "LIST is already the logical type and can't be changed");
logicalTypeAnnotation == null,
"LIST is already the logical type and can't be changed. Current annotation: %s",
logicalTypeAnnotation);
Objects.requireNonNull(elementType, "List element type cannot be null");

GroupBuilder<GroupType> builder = buildGroup(repetition).as(OriginalType.LIST);
Expand Down