Fix tidy reports #140
Merged
Fix tidy reports #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeveloperPaul123
approved these changes
Apr 27, 2025
Member
DeveloperPaul123
left a comment
DeveloperPaul123
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment.
Comment on lines
+37
to
+38
| SYSTEM = $(shell uname -s) | ||
| BUILD = $(BUILDROOT)/$(SYSTEM)/$(SANITIZER) |
Member
There was a problem hiding this comment.
Looks like there might be a mixture of tabs and spaces in this file. Might be nice to be consistent about using one or the other if possible.
Member
Author
There was a problem hiding this comment.
Tabs at the start of the line are significant in Makefiles. There are some tabs at the start of line continuations which could be spaces. I don't think it is an issue but I can fix at some point if that is seen as a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.