Skip to content

Fix tidy reports #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dietmarkuehl merged 4 commits into from
Apr 29, 2025
Merged

Fix tidy reports #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07a96dd
added some tidy errors
dietmarkuehl Apr 27, 2025
4117735
restored src/beman/execution/CMakeLists.txt
dietmarkuehl Apr 27, 2025
041d47e
fix a formatting issue
dietmarkuehl Apr 29, 2025
b443a25
changed not by ! to avoid a formatting issue
dietmarkuehl Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ CXX_FLAGS ?= -g
SANITIZER ?= default
SOURCEDIR = $(CURDIR)
BUILDROOT = build
BUILD = $(BUILDROOT)/$(SANITIZER)
SYSTEM = $(shell uname -s)
BUILD = $(BUILDROOT)/$(SYSTEM)/$(SANITIZER)
Comment on lines +37 to +38
Copy link
Member

@DeveloperPaul123 DeveloperPaul123 Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be a mixture of tabs and spaces in this file. Might be nice to be consistent about using one or the other if possible.

Copy link
Member Author

@dietmarkuehl dietmarkuehl Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs at the start of the line are significant in Makefiles. There are some tabs at the start of line continuations which could be spaces. I don't think it is an issue but I can fix at some point if that is seen as a problem.

EXAMPLE = beman.execution.examples.stop_token
CMAKE_CXX_COMPILER=$(COMPILER)

Expand Down Expand Up @@ -113,6 +114,7 @@ check:
done | tsort > /dev/null

build/$(SANITIZER)/compile_commands.json: $(SANITIZER)

clang-tidy: $(BUILD)/compile_commands.json
run-clang-tidy -p $(BUILD) tests examples

Expand All @@ -138,7 +140,7 @@ clean-doc:
$(RM) -r docs/html docs/latex

clean: clean-doc
$(RM) -r $(BUILD)
cmake --build $(BUILD) --target clean
$(RM) mkerr olderr *~

distclean: clean
Expand Down
3 changes: 2 additions & 1 deletion include/beman/execution/detail/sched_attrs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ class sched_attrs {

public:
template <typename S>
explicit sched_attrs(S s) : sched(::std::move(s)) {}
requires(!::std::same_as<sched_attrs, ::std::remove_cvref_t<S>>)
explicit sched_attrs(S&& s) : sched(::std::forward<S>(s)) {}

template <typename Tag>
auto query(const ::beman::execution::get_completion_scheduler_t<Tag>&) const noexcept {
Expand Down
Loading