Use development provisioning profiles managed without Fastlane #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have internal tooling to manage those in a way that does not require developers to set up Ruby for local every-day work. Internal refs: - pdnsEh-1ZG-p2 - https://linear.app/a8c/issue/AINFRA-245
mokagio
commented
Apr 29, 2025
Comment on lines
106
to
108
| lane :set_up_code_signing_app_store do |readonly: true| | ||
| set_up_code_signing(type: 'appstore', readonly: readonly) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
I could have refined this and removed the two-step abstraction, consolidating everything in the set_up_code_singing lane.
I decided against it to 1) save time 2) leaving the code like this doesn't make it much more complex and it has the advantage of being already layered in case we'll add additional code signing types in the future.
AliSoftware
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have internal tooling to manage those in a way that does not require developers to set up Ruby for local every-day work.
Internal refs:
The screenshot below shows Xcode successfully resolving the provisioning profile and development certificate pairs and the app running for Mac Catalyst: