Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,11 @@ platform :ios do

lane :set_up_code_signing do |readonly: true|
set_up_code_signing_app_store(readonly: readonly)
set_up_code_signing_deveploment(readonly: readonly)
end

lane :set_up_code_signing_app_store do |readonly: true|
set_up_code_signing(type: 'appstore', readonly: readonly)
end
Comment on lines 106 to 108
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have refined this and removed the two-step abstraction, consolidating everything in the set_up_code_singing lane.

I decided against it to 1) save time 2) leaving the code like this doesn't make it much more complex and it has the advantage of being already layered in case we'll add additional code signing types in the future.


lane :set_up_code_signing_deveploment do |readonly: true|
set_up_code_signing(type: 'development', readonly: readonly)
end
end

def bump_build_number
Expand Down
4 changes: 2 additions & 2 deletions ios/App/App/Debug.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
// specified below.
CODE_SIGN_IDENTITY = Apple Development: Created via API (886NX39KP6)

PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*] = match Development com.ellavandurpe.blocknotes
PROVISIONING_PROFILE_SPECIFIER[sdk=macosx*] = match Development com.ellavandurpe.blocknotes catalyst
PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*] = Blocknotes iOS Development
PROVISIONING_PROFILE_SPECIFIER[sdk=macosx*] = Blocknotes macOS Catalyst Development
Loading