Updates on adding Synchroni Devices by AranRhiod · Pull Request #754 · brainflow-dev/brainflow

AranRhiod · 2025-01-04T21:49:18Z

Adding support for the following Synchroni Devices:
Synchroni_Uno
Synchroni_Trio
Synchroni_Pento
Synchroni_Octo
OB3000

Requires information of boards, Require setup of child board class and implementation of virtual methods needbuild.cmakenew files and directories to target include directories

Need implementation of the Synchroni board class

added info and binding of: Uno Tro Pento Octo Neo Synchroni board

TODO added

Changed boardIDs to be universal for synchroni devices. update on read_data()

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>

…SI/brainflow into Synchroni_Device_Setup

Data parsing implmentation in progress. stream ends abnormally with no data during wait time with current command send for start_stream. checking command with hardware department

…SI/brainflow into Synchroni_Device_Setup

This reverts commit df382a8.

Dropping tests that was not excluded from previous merge in fork

roping tests that was not excluded from previous merge

Andrey1994

would be much easier wo need to hide communication protocol and just implement parsing in BrainFlow using BleLibBoard... but its fine, I think brainflow part for adding new board is ok

Andrey1994 · 2025-01-05T19:14:10Z

.gitignore

-build/
+build/
+*.DS_Store
+/tryinstall/


this should be removed

removed and discarding changes resulted from changes in gitignore

Andrey1994 · 2025-01-05T19:14:39Z

CMakeLists.txt

@@ -1,4 +1,9 @@
-cmake_minimum_required (VERSION 3.13)
+if (APPLE)


why is it changed?

Because MAC version requires XCFramework (new format of library), so it will require latest version of CMake

Andrey1994 · 2025-01-05T19:18:28Z

julia_package/brainflow/src/board_shim.jl

    NEUROPAWN_KNIGHT_BOARD = 57
+    SYNCHRONI_TRIO_3_CHANNELS_BOARD = 58
+    SYNCHRONI_OCTO_8_CHANNELS_BOARD = 59
+    SYNCHRONI_PENTO_8_CHANNELS_BOARD = 62


60 and 61 are missed, see no reasons for such gaps, so please change board ids

fixed ID in new commit

Andrey1994 · 2025-01-05T19:19:36Z

java_package/brainflow/src/main/java/brainflow/BoardIds.java

-    NEUROPAWN_KNIGHT_BOARD(57);
+    NEUROPAWN_KNIGHT_BOARD(57),
+    SYNCHRONI_TRIO_3_CHANNELS_BOARD(58),
+    SYNCHRONI_OCTO_8_CHANNELS_BOARD(59),


60 is missed, such ids should match each other among languages otherwise it will not work

Fixed id in new commit

Andrey1994 · 2025-01-05T19:20:03Z

matlab_package/brainflow/BoardIds.m

        NEUROPAWN_KNIGHT_BOARD(57)
+        SYNCHRONI_TRIO_3_CHANNELS_BOARD(58)
+        SYNCHRONI_OCTO_8_CHANNELS_BOARD(59)
+


60 is missed

fixed ID in new commit

Andrey1994 · 2025-01-05T19:23:08Z

python_package/examples/tests/brainflow_get_data.py

    params.file = args.file
    params.master_board = args.master_board
-
+    


this file should not be changed

Changes removed

Andrey1994 · 2025-01-05T19:25:57Z

src/board_controller/brainflow_boards.cpp

+        {"timestamp_channel", 4},
+        {"marker_channel", 5},
+        {"num_rows", 6},
+        {"eeg_channels", {1, 2}},


is it really ecg channel only? for the cases where electrode can be connected to everything and there is no way to know it in front we just write eeg_channels emg_channels and ecg_channels to the same values(e.g. openbci ganglion)

We recommend user use according to IFU

Andrey1994 · 2025-01-05T19:31:03Z

src/board_controller/synchroni/synchroni_board.cpp

+    std::tuple<std::string> info =
+        std::make_tuple (params.mac_address);
+    return func ((void*)&info);
+//    return s_close_device((void*)params.mac_address.c_str());


would be good to remove such comments here and in other places

CLeaned up synchroni_board.cpp

Andrey1994 · 2025-01-05T19:32:20Z

third_party/SimpleBLE/.github/workflows/ci_cpp_release.yml

@@ -0,0 +1,205 @@
+name: Cpp Release


all changes from simpleble should be removed from this change, it doesnt even use ble_board anymore

Resetting the SimpleBLE folder to #753.

Andrey1994 · 2025-01-05T19:38:51Z

...b/mac/sensor.xcframework/ios-arm64_x86_64-simulator/sensor.framework/Headers/BLEPeripheral.h

@@ -0,0 +1,102 @@
+//


is there any difference between all these macos headers for different archs? I guess no, so can the headers folder be made common for all of them?

Because MAC version requires XCFramework (new format of library), this is part of released xcframework

build/ *.DS_Store /tryinstall/ removed from git ignore discarding changes

Fixing id gaps, id 60 reserved for OB5000 Fixing test changed

Andrey1994 · 2025-01-12T20:42:05Z

will make another pass on review when jobs are green, seems like there are multile compilation issues. From Linux job:

make[2]: Entering directory '/home/runner/work/brainflow/brainflow/build'
[ 19%] Building CXX object CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o
/usr/bin/c++ -DSynchroniLib_EXPORTS -DUNICODE -D_UNICODE -I/home/runner/work/brainflow/brainflow/third_party/synchroni/src/inc -I/home/runner/work/brainflow/brainflow/third_party/synchroni/inc -I/home/runner/work/brainflow/brainflow/third_party/synchroni/.. -I/home/runner/work/brainflow/brainflow/src/utils/inc -I/home/runner/work/brainflow/brainflow/src/board_controller/inc -I/home/runner/work/brainflow/brainflow/third_party/json -O3 -DNDEBUG -fPIC -fvisibility=hidden -Werror -Wno-varargs -Wno-error=deprecated-declarations -std=gnu++11 -MD -MT CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o -MF CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o.d -o CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o -c /home/runner/work/brainflow/brainflow/third_party/synchroni/src/synchroni_wrapper.cpp
In file included from /home/runner/work/brainflow/brainflow/third_party/synchroni/inc/SensorController.hpp:7,
                 from /home/runner/work/brainflow/brainflow/third_party/synchroni/src/synchroni_wrapper.cpp:4:
/home/runner/work/brainflow/brainflow/third_party/synchroni/inc/SensorProfile.hpp:8:10: fatal error: sensorData.hpp: No such file or directory
    8 | #include "sensorData.hpp"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/SynchroniLib.dir/build.make:79: CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o] Error 1
make[2]: Leaving directory '/home/runner/work/brainflow/brainflow/build'
make[1]: *** [CMakeFiles/Makefile2:243: CMakeFiles/SynchroniLib.dir/all] Error 2
make[1]: Leaving directory '/home/runner/work/brainflow/brainflow/build'
make: *** [Makefile:149: all] Error 2

And on windows there is:

 Creating library D:/a/brainflow/brainflow/compiled/Release/SynchroniLib.lib and object D:/a/brainflow/brainflow/compiled/Release/SynchroniLib.exp
synchroni_wrapper.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class std::shared_ptr<class sensor::SensorController> __cdecl sensor::SensorController::getInstance(void)" (__imp_?getInstance@SensorController@sensor@@SA?AV?$shared_ptr@VSensorController@sensor@@@std@@XZ) referenced in function "public: __thiscall <lambda_17836e33b7e75ec10528d0408001c543>::operator()(void)const " (??R<lambda_17836e33b7e75ec10528d0408001c543>@@QBE@XZ) [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
synchroni_wrapper.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static void __cdecl sensor::SensorController::destory(void)" (__imp_?destory@SensorController@sensor@@SAXXZ) referenced in function _DllMain@12 [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
D:\a\brainflow\brainflow\third_party\synchroni\lib\windows\ForRelease\sensor.lib : warning LNK4272: library machine type 'x64' conflicts with target machine type 'x86' [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
D:\a\brainflow\brainflow\compiled\Release\SynchroniLib.dll : fatal error LNK1120: 2 unresolved externals [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
  Building Custom Rule D:/a/brainflow/brainflow/third_party/fmt/CMakeLists.txt

disable build for linux

yecq · 2025-01-14T03:44:08Z

will make another pass on review when jobs are green, seems like there are multile compilation issues. From Linux job:

make[2]: Entering directory '/home/runner/work/brainflow/brainflow/build'
[ 19%] Building CXX object CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o
/usr/bin/c++ -DSynchroniLib_EXPORTS -DUNICODE -D_UNICODE -I/home/runner/work/brainflow/brainflow/third_party/synchroni/src/inc -I/home/runner/work/brainflow/brainflow/third_party/synchroni/inc -I/home/runner/work/brainflow/brainflow/third_party/synchroni/.. -I/home/runner/work/brainflow/brainflow/src/utils/inc -I/home/runner/work/brainflow/brainflow/src/board_controller/inc -I/home/runner/work/brainflow/brainflow/third_party/json -O3 -DNDEBUG -fPIC -fvisibility=hidden -Werror -Wno-varargs -Wno-error=deprecated-declarations -std=gnu++11 -MD -MT CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o -MF CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o.d -o CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o -c /home/runner/work/brainflow/brainflow/third_party/synchroni/src/synchroni_wrapper.cpp
In file included from /home/runner/work/brainflow/brainflow/third_party/synchroni/inc/SensorController.hpp:7,
                 from /home/runner/work/brainflow/brainflow/third_party/synchroni/src/synchroni_wrapper.cpp:4:
/home/runner/work/brainflow/brainflow/third_party/synchroni/inc/SensorProfile.hpp:8:10: fatal error: sensorData.hpp: No such file or directory
    8 | #include "sensorData.hpp"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/SynchroniLib.dir/build.make:79: CMakeFiles/SynchroniLib.dir/third_party/synchroni/src/synchroni_wrapper.cpp.o] Error 1
make[2]: Leaving directory '/home/runner/work/brainflow/brainflow/build'
make[1]: *** [CMakeFiles/Makefile2:243: CMakeFiles/SynchroniLib.dir/all] Error 2
make[1]: Leaving directory '/home/runner/work/brainflow/brainflow/build'
make: *** [Makefile:149: all] Error 2

And on windows there is:

 Creating library D:/a/brainflow/brainflow/compiled/Release/SynchroniLib.lib and object D:/a/brainflow/brainflow/compiled/Release/SynchroniLib.exp
synchroni_wrapper.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class std::shared_ptr<class sensor::SensorController> __cdecl sensor::SensorController::getInstance(void)" (__imp_?getInstance@SensorController@sensor@@SA?AV?$shared_ptr@VSensorController@sensor@@@std@@XZ) referenced in function "public: __thiscall <lambda_17836e33b7e75ec10528d0408001c543>::operator()(void)const " (??R<lambda_17836e33b7e75ec10528d0408001c543>@@QBE@XZ) [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
synchroni_wrapper.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static void __cdecl sensor::SensorController::destory(void)" (__imp_?destory@SensorController@sensor@@SAXXZ) referenced in function _DllMain@12 [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
D:\a\brainflow\brainflow\third_party\synchroni\lib\windows\ForRelease\sensor.lib : warning LNK4272: library machine type 'x64' conflicts with target machine type 'x86' [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
D:\a\brainflow\brainflow\compiled\Release\SynchroniLib.dll : fatal error LNK1120: 2 unresolved externals [D:\a\brainflow\brainflow\build32\SynchroniLib.vcxproj]
  Building Custom Rule D:/a/brainflow/brainflow/third_party/fmt/CMakeLists.txt

I've submited, disable linux build, please check

Andrey1994 · 2025-01-23T08:28:27Z

sorry for delays, for the 1st time contributors CI jobs do not start automatically, so I am approving them manually and there is some delay here

AranRhiod · 2025-01-24T01:25:57Z

sorry for delays, for the 1st time contributors CI jobs do not start automatically, so I am approving them manually and there is some delay here

Np, I'll inform Ye and Tony

Andrey1994

looks good, just two minor comments about cmake
also, which OSes and devices have you tested with brainflow api so far? could you share some recorded files and do you want me to test any particular OS or config?

Andrey1994 · 2025-01-26T19:32:06Z

src/board_controller/build.cmake


+if (BUILD_SYNCHRONI_SDK)
+    if (ANDROID)
+


add a warning message here that its not currently supported

Andrey1994 · 2025-01-26T19:32:49Z

src/board_controller/build.cmake

    ${BOARD_CONTROLLER_SRC}
 )

-#if (ANDROID AND BUILD_BLE)


thats not related to syncroni devices and should be restored

Andrey1994 · 2025-01-26T19:39:33Z

I will update docs and website, do you have any preferred images for that? I need smth with no background or white backgraound and one square image for the website and any image you like for docs

AranRhiod · 2025-01-26T19:43:52Z

I’ll ask Tony for a set of pictures taken earlier, will get back to you asap Regards, Ziyue Wang Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Andrey Parfenov ***@***.***> Sent: Sunday, January 26, 2025 2:39:55 PM To: brainflow-dev/brainflow ***@***.***> Cc: Ziyue Wang ***@***.***>; Author ***@***.***> Subject: Re: [brainflow-dev/brainflow] Updates on adding Synchroni Devices (PR #754) I will update docs and website, do you have any preferred images for that? I need smth with no background or white backgraound and one square image for the website and any image you like for docs — Reply to this email directly, view it on GitHub<#754 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BKHTHZKBDKRBVGARUE2HR4D2MU2YXAVCNFSM6AAAAABUTOUU52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGU3DIMBWHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

AranRhiod and others added 30 commits August 1, 2024 23:33

Synchroni Board setup incomplete

ec6a2ca

Requires information of boards, Require setup of child board class and implementation of virtual methods needbuild.cmakenew files and directories to target include directories

reconfigure to add Synchroni Trio board

57fc0ff

Need implementation of the Synchroni board class

adding synchroni to cmake

a02013d

Synchroni board info added

0603f58

added info and binding of: Uno Tro Pento Octo Neo Synchroni board

build.cmake update

786de8a

read_data development

8535f3b

definition of known fields and more

db31e3e

read_data update

e7f491b

TODO added

start_stream update

e57de14

Update for synchroni intergration

4101311

Changed boardIDs to be universal for synchroni devices. update on read_data()

Build successful

3f2d800

wip: bump simpleble and add syncroni device

fb080bd

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>

bump upload artifact to v3

a3bbe08

Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>

stuff

df382a8

Merge branch 'Synchroni_Device_Setup' of https://github.com/Synchroni…

db9f21b

…SI/brainflow into Synchroni_Device_Setup

Data Parsing

d44f2d1

Data parsing implmentation in progress. stream ends abnormally with no data during wait time with current command send for start_stream. checking command with hardware department

Merge branch 'Synchroni_Device_Setup' of https://github.com/Synchroni…

03fbcdf

…SI/brainflow into Synchroni_Device_Setup

Revert "stuff"

ffd34dc

This reverts commit df382a8.

Merge branch 'syncroni' into Synchroni_Device_Setup

cd3b491

test mac version

522da1c

try windows version

82877ac

forgot dylib

2e1d9f9

fix windows build

4e77a44

fix release session

92e0d58

support OB3000

fb940f7

add more test

81aacfc

fix crash

5d42765

fix crash

fcaf827

fix set ecg

46fdcf5

change board ids

73e1841

AranRhiod added 4 commits January 4, 2025 16:46

Merge branch 'Synchroni_Device_Setup'

055c439

Merge remote-tracking branch 'upstream/master'

f5216c8

Dropping tests

ec33752

Dropping tests that was not excluded from previous merge in fork

Drropping tests

24c0ce0

roping tests that was not excluded from previous merge

Andrey1994 requested changes Jan 5, 2025

View reviewed changes

AranRhiod added 7 commits January 7, 2025 11:26

revert simpleBLE to brainflow-dev#753

9db0634

Remove from git ignore

c9f2edc

build/ *.DS_Store /tryinstall/ removed from git ignore discarding changes

cleanup synchroni_board.cpp

a0d9d64

removing changes in brainflow_get_data.py

3b4bead

ID fixes and fixing example

3f84870

Fixing id gaps, id 60 reserved for OB5000 Fixing test changed

Delete accidentally copy pasted file

31514f6

reset plot real time file

314a68c

AranRhiod requested a review from Andrey1994 January 7, 2025 19:10

add win32 lib

3df9ab9

disable build for linux

yecq added 7 commits January 16, 2025 10:35

forgot python pip setup files

6f04690

add linux support

a5b1d33

fix compile errors

15b55b7

try fix macos compile

63989e9

fix compile

49afe19

try fix macos compile

12d62ff

fix compile

b73599e

Andrey1994 reviewed Jan 26, 2025

View reviewed changes

Andrey1994 merged commit 41a1d4a into brainflow-dev:master Jan 28, 2025
11 checks passed

serhii-matsyshyn mentioned this pull request Mar 3, 2025

Adding BioListener boards support #759

Merged

		@@ -1,4 +1,9 @@
		cmake_minimum_required (VERSION 3.13)
		if (APPLE)

		params.file = args.file
		params.master_board = args.master_board

Uh oh!

Conversation

AranRhiod commented Jan 4, 2025

Uh oh!

Andrey1994 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andrey1994 commented Jan 12, 2025

Uh oh!

yecq commented Jan 14, 2025

Uh oh!

Andrey1994 commented Jan 23, 2025

Uh oh!

AranRhiod commented Jan 24, 2025

Uh oh!

Andrey1994 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andrey1994 commented Jan 26, 2025

Uh oh!

AranRhiod commented Jan 26, 2025 via email

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants