feat: support algo trades #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for futuresCancelAlgo method in BinanceStaticTests.
carlosmiei
reviewed
Dec 9, 2025
| { | ||
| $request = []; | ||
| if ($algoId) { | ||
| $request['algoId'] = $algoId; |
Contributor
Author
There was a problem hiding this comment.
Yeah, I checked both algoId and clientAlgoId. Both works good in camel case.
Contributor
Author
There was a problem hiding this comment.
Here must be camel case in the docs:
https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Query-Algo-Order
Collaborator
There was a problem hiding this comment.
hum weird, I'm pretty sure the exchange is tripping here does not make sense to have both (unless they updated the docs in the meantime)
carlosmiei
reviewed
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.