-
Notifications
You must be signed in to change notification settings - Fork 499
feat: support algo trades #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3904db9
feat(futuresOrder): algo orders support added
yzh-pelle 5c5992f
test: testFuturesAlgoOrder added
yzh-pelle 63677cf
feat: futuresAlgoOrderStatus added
yzh-pelle 7645bc9
test: futuresAlgoOrderStatus testing added
yzh-pelle 708aacb
feat: methods for canceling algo orders added
yzh-pelle d6dc0f5
test: testFuturesCancelOpenAlgoOrders added
yzh-pelle 1e5c9c6
feat: methods for fetching algo orders added
yzh-pelle 08b2146
fix: correct file updated
yzh-pelle 54a9c58
test: static tests for fetching algo orders added
yzh-pelle c00c03e
feat: futuresCancelAlgo updated
yzh-pelle 3470eed
test: testFuturesCancelAlgo added
yzh-pelle 9b2cb2b
fix: comment removed
yzh-pelle 75bf0ca
feat: futuresCancelAlgo updated
yzh-pelle 63d365a
test: testFuturesCancelAlgo updated
yzh-pelle 96b7c51
test: testFuturesCancelAlgoByClientAlgoId added
yzh-pelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yzh-pelle u sure it is not
algoidlowercase?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I checked both
algoIdandclientAlgoId. Both works good in camel case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yzh-pelle but we should follow the docs

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here must be camel case in the docs:

https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Query-Algo-Order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum weird, I'm pretty sure the exchange is tripping here does not make sense to have both (unless they updated the docs in the meantime)