chore(event-reporter): refactoring, variables grouping, code splitting #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kingMetadata to pass data between methods
…EntityParentApp to pass data between methods
…Resource to pass data between methods, created new methods to group logic inside getResourceEventPayload
oleksandr-codefresh
changed the title
pasha-codefresh
suggested changes
Nov 7, 2024
| func (s *applicationEventReporter) resolveApplicationVersions(ctx context.Context, a *appv1.Application, logCtx *log.Entry) *apiclient.ApplicationVersions { | ||
| syncRevision := utils.GetOperationStateRevision(a) | ||
| var applicationVersions *apiclient.ApplicationVersions | ||
| if syncRevision != nil { |
There was a problem hiding this comment.
lets rid of else condition and make it nicer. also you dont need applicationVersions as variable
| ) ([]byte, error) { | ||
| // no actual or desired state, don't send event | ||
| u := &unstructured.Unstructured{} | ||
| apiVersion := rr.rs.Version |
There was a problem hiding this comment.
create function inside ReportedResource that will build you api version, like rr.rs.GetApiVersion
oleksandr-codefresh
force-pushed
the
CR-23668-refactoring-variables-grouping
branch
from
c42708b to
5230e16
Compare
pasha-codefresh
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: