refactor: Fix phpstan codeigniter.modelArgumentInstanceOf#9391
Closed
neznaika0 wants to merge 3 commits intocodeigniter4:developfrom
Closed
refactor: Fix phpstan codeigniter.modelArgumentInstanceOf#9391neznaika0 wants to merge 3 commits intocodeigniter4:developfrom
neznaika0 wants to merge 3 commits intocodeigniter4:developfrom
Conversation
Member
neznaika0
force-pushed
the
refactor/phpstan-model-argument-instanceof
branch
from
02138c8 to
2fa1eee
Compare
Contributor
Author
|
RESTFul uses |
paulbalandan
approved these changes
Feb 7, 2025
samsonasik
reviewed
Feb 15, 2025
system/RESTful/BaseResource.php
Outdated
| if ($which !== null) { | ||
| $this->model = is_object($which) ? $which : null; | ||
| $this->modelName = is_object($which) ? null : $which; | ||
| $this->modelName = is_object($which) ? '' : $which; |
Member
There was a problem hiding this comment.
why this change, any test for it ?
Contributor
Author
There was a problem hiding this comment.
$this->modelName is always a string. Why is there null there? model() will throw an error if you pass null.
What test do you need? You even need to change the type $this->modelName
Contributor
Author
There was a problem hiding this comment.
We didn't agree, I'll just give it back.
neznaika0
force-pushed
the
refactor/phpstan-model-argument-instanceof
branch
from
2fa1eee to
406c85e
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I need help.
I still don't understand how to work with generics. I can add simple hints, but any condition raises questions.
How do I specify here "If $which is
class-string<Model> ? class-string<Model> : Model|object|string|null" and then update the hint formodel($this->modelName)The phpstan documentation is small. There is no description of most use cases. Did I miss something?
Checklist: