Skip to content

🤖 perf: skip code signing in merge queue to enable parallel builds #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibetitsmike merged 1 commit into from
Dec 3, 2025
Merged

🤖 perf: skip code signing in merge queue to enable parallel builds #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,8 @@ jobs:

- uses: ./.github/actions/setup-mux

# Skip signing setup for PRs - electron-builder skips signing anyway,
# but setting CSC_LINK forces our Makefile to build sequentially.
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
- name: Setup code signing
if: github.event_name != 'pull_request'
run: ./scripts/setup-macos-signing.sh
env:
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
AC_APIKEY_P8_BASE64: ${{ secrets.AC_APIKEY_P8_BASE64 }}
AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }}
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}

- name: Verify signing setup
if: github.event_name != 'pull_request'
run: |
if [ -n "${CSC_LINK:-}" ]; then
echo "✅ Code signing enabled"
security list-keychains -d user
security find-identity -v -p codesigning
else
echo "⚠️ Code signing NOT enabled"
fi

# No code signing - releases use release.yml (triggered by tag publish).
# Without CSC_LINK, x64 and arm64 builds run in parallel (~12 min faster).
- name: Package for macOS
run: make dist-mac

Expand Down