🤖 perf: skip code signing in merge queue to enable parallel builds #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
force-pushed
the
fix-macos-package-build-time
branch
2 times, most recently
from
fddf0f2 to
b74e83c
Compare
The macOS build was taking 24+ minutes because code signing forced sequential x64+arm64 builds (to avoid keychain race conditions). Removed signing entirely from build.yml since releases use release.yml (triggered by tag publish). This lets both architectures build in parallel. - Before: 24m40s (sequential with signing) - After: ~4m (parallel, no signing) Generated with mux
ibetitsmike
force-pushed
the
fix-macos-package-build-time
branch
from
b74e83c to
4563409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS build workflow was taking 24+ minutes because code signing was enabled for
merge_groupevents. This forced sequential x64+arm64 builds to avoid keychain race conditions.Since merge queue builds don't need signed artifacts (only releases do), we can safely skip signing and let both architectures build in parallel. This should cut the macOS build time roughly in half (~12 min).
Before: 24m40s for macOS build
After: Expected ~12 min (parallel x64+arm64 builds)
Generated with
mux