utils: honour recursive glob patterns in _should_include (#275) #279
+72
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
atomics/**/*.mdand similar patterns never matched, because_should_includetreated all patterns as fixed-depth globs.This patch adds dedicated logic that distinguishes recursive (
**) from non-recursive patterns and introduces directory-aware checks so we only descend into directories that could contain matches.✅ Fixes: #275
.mdfiles, but the directory-structure output still lists the directories themselves even when they contain no matched files (e.g.atomics/Indexes/Attack-Navigator-Layers/,atomics/T1003.003/src/). A follow-up PR will tackle this.