[Python] Update package version during CLI release #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
pietern
reviewed
Apr 8, 2025
Contributor
There was a problem hiding this comment.
This LGTM, but I'm not familiar with the "version" stanza.
It also loses the ability to disambiguate dev versions from the released one. Any way we could address that and retain a +dev suffix, or some other indicator that a built wheel is a development copy?
@andrewnester Can you TAL as well?
Collaborator
Author
|
Databricks SDK for Python doesn't use |
shreyas-goenka
approved these changes
Apr 11, 2025
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
## Changes Add release workflow to publish `databricks-bundles` PyPi package Should be merged after #2676 ## Why It publishes PyPi package that is co-versioned with CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the
databricks-bundlespackage version during the CLI release process.Flit normally supports reading the
version.pyfile directly, but in our setup, it doesn't work. We have a parentdatabrickspackage with a shared__init__.py. Flit expects theversion.pyto be placed directly alongside the parent package, which would set the version for any Databricks package.versionproperty in.codegen.jsonis handled through replacement. Any additional content in the file remains intact. Therefore, this method works for updating thepyproject.tomlwithout the need to inline the entire content.Why
We want to keep the CLI version in sync with the Python code.
Tests
I've tested manually by commenting out parts of tagging.py