Translate relative paths root_path and glob.include for pipelines
#2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
root_path and glob.includeroot_path and glob.include for pipelines
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
May 27, 2025
| >>> echo HELLO | ||
|
|
||
| === Custom regex can be specified in [[Repl]] section | ||
| === Custom regex can be specified in [[Repls]] section |
Contributor
Author
There was a problem hiding this comment.
small typo fix.
pietern
reviewed
May 27, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
approved these changes
May 27, 2025
pietern
reviewed
May 27, 2025
| @@ -0,0 +1,5 @@ | |||
| bundle: | |||
| name: pipelines_relative_path_translation | |||
Contributor
There was a problem hiding this comment.
One was removed, but this one was kept. Please keep consistency in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Translating these fields is necessary for Lakeflow authoring experience to work well with DABs in the workspace. We expect users to set these fields manually in their bundle config.
For:
root_path: We translate the relative root_path to an absolute path in the workspace. Since we assume that the root_path is within the sync root for the bundle (i.e., it's managed by the bundle), we error if it does not exist or lies outside the bundle root.glob.include: We directly translate relative glob patterns to absolute ones. Performing any client-side validation requires keeping the validation logic in sync with the server-side definition, so for now, we'll omit performing any client-side validation for glob patterns specified inglob.include.Tests
Acceptance tests