-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Windows support #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8d31588 to
558ea91
Compare
558ea91 to
879fc4f
Compare
7b71ffd to
ca35070
Compare
3549eae to
d586255
Compare
0fdc03c to
bca7031
Compare
e687ab6 to
8a55ab6
Compare
| # Disable incremental compilation | ||
| CARGO_INCREMENTAL: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any issues with incremental compilation? Disabling it may slow CI.
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct TermWriter { | ||
| pub debug: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debug flag semantics are a bit confusing - when debug: true, terminal output is suppressed (only goes to logs). Intuitively, I'd expect --debug to mean "show more output", not less.
Could you clarify the intent here? If the purpose is "redirect output to logs only when in debug mode", would a name like log_only or suppress_terminal be clearer?
| if !self.debug { | ||
| (&self.raw_term).write(buf)?; | ||
| } | ||
| debug!("{}", String::from_utf8_lossy(buf).trim()); | ||
| Ok(buf.len()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if !self.debug { | |
| (&self.raw_term).write(buf)?; | |
| } | |
| debug!("{}", String::from_utf8_lossy(buf).trim()); | |
| Ok(buf.len()) | |
| let written = if !self.debug { | |
| (&self.raw_term).write(buf)? | |
| } else { | |
| buf.len() | |
| }; | |
| debug!("{}", String::from_utf8_lossy(&buf[..written]).trim()); | |
| Ok(written) |
The Write trait contract states that write() returns the number of bytes actually written.
Not to be merged until the compatible ic-wasm is released