Skip to content

Conversation

@adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Jan 14, 2026

Not to be merged until the compatible ic-wasm is released

@adamspofford-dfinity adamspofford-dfinity force-pushed the spofford/windows branch 2 times, most recently from 8d31588 to 558ea91 Compare January 15, 2026 18:24
@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review January 21, 2026 02:42
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner January 21, 2026 02:42
Comment on lines +14 to +15
# Disable incremental compilation
CARGO_INCREMENTAL: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any issues with incremental compilation? Disabling it may slow CI.


#[derive(Debug, Clone)]
pub struct TermWriter {
pub debug: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug flag semantics are a bit confusing - when debug: true, terminal output is suppressed (only goes to logs). Intuitively, I'd expect --debug to mean "show more output", not less.

Could you clarify the intent here? If the purpose is "redirect output to logs only when in debug mode", would a name like log_only or suppress_terminal be clearer?

Comment on lines +527 to +531
if !self.debug {
(&self.raw_term).write(buf)?;
}
debug!("{}", String::from_utf8_lossy(buf).trim());
Ok(buf.len())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if !self.debug {
(&self.raw_term).write(buf)?;
}
debug!("{}", String::from_utf8_lossy(buf).trim());
Ok(buf.len())
let written = if !self.debug {
(&self.raw_term).write(buf)?
} else {
buf.len()
};
debug!("{}", String::from_utf8_lossy(&buf[..written]).trim());
Ok(written)

The Write trait contract states that write() returns the number of bytes actually written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants