-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Windows support #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
dbe77b0
support docker images
adamspofford-dfinity a0bb0b4
error handling + windows
adamspofford-dfinity 518050c
container preservation
adamspofford-dfinity 8a8e9e5
.
adamspofford-dfinity e05cc00
windows
adamspofford-dfinity d0219ce
container args
adamspofford-dfinity 68fb26c
remove special term
adamspofford-dfinity 222f3ad
locate git bash
adamspofford-dfinity 324bde4
Change default network to docker on windows
adamspofford-dfinity c602680
Merge branch 'main' into spofford/windows
adamspofford-dfinity af95a26
new fields
adamspofford-dfinity df3c389
Merge branch 'main' into spofford/windows
adamspofford-dfinity d525c30
include windows builds in CI
adamspofford-dfinity cfa5d56
Revert default network change
adamspofford-dfinity 929a23e
Convert native networks to containers on windows
adamspofford-dfinity 99d903f
Add ii config
adamspofford-dfinity af109f2
Wrap terminal output
adamspofford-dfinity 633c780
use ctrl-break for process groups
adamspofford-dfinity c0f5349
quote filenames in templated sh calls
adamspofford-dfinity a7d87f3
dockerate start_network_with_flags
adamspofford-dfinity 879fc4f
you can't override $HOME so use portable mode
adamspofford-dfinity 3106c80
print port for all sources
adamspofford-dfinity bb153fe
remove unc prefix from expected path
adamspofford-dfinity 5d7e2d2
windows stops use container id
adamspofford-dfinity 3921a42
Add windows to e2e matrix
adamspofford-dfinity ca35070
detect with winreg instead of pathsearch
adamspofford-dfinity 6161702
clean up
adamspofford-dfinity 51cb0c5
Better message
adamspofford-dfinity 76be34f
Quote unit tests as well
adamspofford-dfinity 77298a4
Never use unprefixed bash because it may be wsl bash
adamspofford-dfinity e03517c
Cache before installing
adamspofford-dfinity 482dba0
Add explicit arch to docker commands
adamspofford-dfinity 61c68f8
Set up docker with tcp
adamspofford-dfinity bd47875
.
adamspofford-dfinity 4a1b0b8
There's an action for this
adamspofford-dfinity 6a2843f
Normalize lf
adamspofford-dfinity c63a16e
Add envvar for WSL2 docker path conversion
adamspofford-dfinity f23616d
Reproduce tcp check in stop
adamspofford-dfinity 581be73
Merge branch 'main' into spofford/windows
adamspofford-dfinity 20232b9
Fix merged tests
adamspofford-dfinity c541ec0
Remove 8.3 names from cwd check
adamspofford-dfinity 514f74e
Update to windows-2025 to remove the need for `wsl --update`
adamspofford-dfinity 5e5c095
Shrink cache
adamspofford-dfinity cd03a85
Merge branch 'main' into spofford/windows
adamspofford-dfinity 88a9ac2
merge broke the build
adamspofford-dfinity 2704201
Move status dir to dockerd host when in wsl mode
adamspofford-dfinity 021dfd1
Always use wslpath
adamspofford-dfinity af82b6b
better msg
adamspofford-dfinity 87850e2
Merge branch 'main' into spofford/windows
adamspofford-dfinity 33b0d00
Include DISTRO in WSLPATH
adamspofford-dfinity 0a23849
Add polling fallback for file watching
adamspofford-dfinity f036f51
Remove vendored-openssl from the Windows build
adamspofford-dfinity 7377125
Use version nonspecific name (cache loses the context)
adamspofford-dfinity 7306c68
immediately poll
adamspofford-dfinity 2679440
wsl sets a var already
adamspofford-dfinity 5353e7b
Lock for a shorter duration
adamspofford-dfinity bca7031
fix manual flags check
adamspofford-dfinity 4b574a2
Increase timeout to 5m
adamspofford-dfinity 8c628d9
docs
adamspofford-dfinity c7dab56
Update dist
adamspofford-dfinity 8a55ab6
remove unnecessary tmpdir handling
adamspofford-dfinity 733e693
Merge branch 'main' into spofford/windows
adamspofford-dfinity 609e118
Apply suggestion
adamspofford-dfinity 08a8eeb
Simplify conditional term output
adamspofford-dfinity 6c94a2e
Merge branch 'main' into spofford/windows
adamspofford-dfinity f3d8d10
Merge branch 'main' into spofford/windows
adamspofford-dfinity 6d2de37
this is redundant (and wrong)
adamspofford-dfinity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * text=auto eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/usr/bin/env bash | ||
| # This sets up dockerd in a WSL2 container manually. You could probably do this locally if you wanted, | ||
| # but the primary purpose is that GitHub Actions' WSL2 runners aren't set up for hypervisor support, | ||
| # so Docker Desktop's automatic WSL2 integration doesn't work. | ||
| set -ex | ||
| apt-get update | ||
| DEBIAN_FRONTEND=noninteractive apt-get install -y docker.io | ||
| nohup dockerd -H tcp://127.0.0.1:2375 >/var/log/dockerd.log 2>&1 & | ||
| for i in $(seq 1 30); do | ||
| if docker -H tcp://127.0.0.1:2375 info >/dev/null 2>&1; then | ||
| echo Docker ready | ||
| { | ||
| echo DOCKER_HOST=tcp://127.0.0.1:2375 | ||
| echo ICP_CLI_DOCKER_WSL2_DISTRO="$WSL_DISTRO_NAME" | ||
| } >> $GITHUB_ENV | ||
| exit 0 | ||
| fi | ||
| sleep 1 | ||
| done | ||
| cat /var/log/dockerd.log | ||
| exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.