[DO NOT MERGE] Install scripts update validation PR #64672
Conversation
ellahathaway
added
the
* NO MERGE *
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull request overview
This PR updates the .NET install script URLs in the ASP.NET Core repository's build tooling from the Microsoft builds infrastructure (builds.dotnet.microsoft.com) to the new GitHub-hosted install-scripts repository (raw.githubusercontent.com/dotnet/install-scripts). The title indicates this is a validation PR that should not be merged.
- Changes URL source from Microsoft's builds infrastructure to GitHub raw content
- Points to the
mainbranch instead of using version control - Affects both PowerShell and Bash install script retrieval
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/tools.sh | Updates the install script URL in the Bash version of GetDotNetInstallScript function |
| eng/common/tools.ps1 | Updates the install script URL in the PowerShell version of GetDotNetInstallScript function |
| local root=$1 | ||
| local install_script="$root/dotnet-install.sh" | ||
| local install_script_url="https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.sh" | ||
| local install_script_url="https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.sh" |
There was a problem hiding this comment.
The new URL points to the main branch of the install-scripts repository, which means it will always fetch the latest version without any version control. This removes the ability to use a specific, stable version of the install script via the dotnetInstallScriptVersion variable (defined at line 61 with default 'v1').
Consider one of the following approaches:
- If the new repository supports versioned paths, use a URL like
https://raw.githubusercontent.com/dotnet/install-scripts/$dotnetInstallScriptVersion/src/dotnet-install.shto maintain version control - If version control is no longer needed, remove the now-unused
dotnetInstallScriptVersionvariable from line 61 and update the comment at lines 59-60
| Create-Directory $dotnetRoot | ||
| $ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit | ||
| $uri = "https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.ps1" | ||
| $uri = "https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.ps1" |
There was a problem hiding this comment.
The new URL points to the main branch of the install-scripts repository, which means it will always fetch the latest version without any version control. This removes the ability to use a specific, stable version of the install script via the $dotnetInstallScriptVersion variable (defined at line 46 with default 'v1').
Consider one of the following approaches:
- If the new repository supports versioned paths, use a URL like
https://raw.githubusercontent.com/dotnet/install-scripts/$dotnetInstallScriptVersion/src/dotnet-install.ps1to maintain version control - If version control is no longer needed, remove the now-unused
$dotnetInstallScriptVersionvariable from line 46 and update the comment at lines 44-45
1 participant
No description provided.