Skip to content

[23355] Remove deprecated windows-2019 runner #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsanchez15 merged 2 commits into from
Jun 27, 2025
Merged

[23355] Remove deprecated windows-2019 runner #243

rsanchez15 merged 2 commits into from
Jun 27, 2025

Conversation

@rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jun 25, 2025 •
edited by Mario-DL
Loading

Description

This PR updates the Windows GitHub Action Runner from windows-2019 to windows-2022. As Visual Studio 2017 build tools (v141) are no longer installed in this new runner, the PR upgrades also to toolsets to use, moving from v141 (VS2017) and v142 (VS2019) to v142 (VS2019) and v143 (VS2022).

@Mergifyio backport 2.2.x 1.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15
Remove deprecated windows-2019 runner
e241669 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 added this to the v2.3.0 milestone Jun 25, 2025
@rsanchez15 rsanchez15 requested a review from Mario-DL June 26, 2025 06:33
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 26, 2025
Mario-DL
Mario-DL suggested changes Jun 26, 2025
View reviewed changes
@rsanchez15
Add matrix to windows-ci
4b5e9da 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL June 26, 2025 10:04
@Mario-DL
Copy link
Contributor

Mario-DL commented Jun 26, 2025

Nigthly run here https://github.com/eProsima/Fast-DDS-python/actions/runs/15898959763

Mario-DL
Mario-DL previously approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CIs

@rsanchez15 rsanchez15 force-pushed the feature/remove-windows-2019 branch from b6ac63e to 67fed16 Compare June 26, 2025 13:38
@rsanchez15 rsanchez15 requested a review from Mario-DL June 26, 2025 13:41
@rsanchez15 rsanchez15 force-pushed the feature/remove-windows-2019 branch from 67fed16 to 4b5e9da Compare June 26, 2025 14:06
@rsanchez15 rsanchez15 requested review from Mario-DL and removed request for Mario-DL June 26, 2025 14:07
@rsanchez15 rsanchez15 merged commit 19115c5 into main Jun 27, 2025
26 of 28 checks passed
@rsanchez15 rsanchez15 deleted the feature/remove-windows-2019 branch June 27, 2025 05:40
@rsanchez15
Copy link
Contributor Author

rsanchez15 commented Jun 27, 2025

@Mergifyio backport 2.2.x 1.4.x

@mergify
Copy link

mergify bot commented Jun 27, 2025 •
edited
Loading

backport 2.2.x 1.4.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 27, 2025
@rsanchez15 @mergify
Remove deprecated windows-2019 runner (#243)
e6a69f7 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

# Conflicts:
#	.github/workflows/nightly-windows-ci.yml
#	.github/workflows/weekly-windows-ci.yml
mergify bot pushed a commit that referenced this pull request Jun 27, 2025
@rsanchez15 @mergify
Remove deprecated windows-2019 runner (#243)
7018190 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

# Conflicts:
#	.github/workflows/nightly-windows-ci.yml
#	.github/workflows/weekly-windows-ci.yml
#	.github/workflows/windows-ci.yml
This was referenced Jun 27, 2025
Merged
Merged
MiguelCompany pushed a commit that referenced this pull request Jul 18, 2025
@rsanchez15 @MiguelCompany
Remove deprecated windows-2019 runner (#243)
706e387 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jul 18, 2025
@mergify @rsanchez15
Remove deprecated windows-2019 runner (#243) (#244)
275712d 
* Remove deprecated windows-2019 runner



* Add matrix to windows-ci



---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
richiware pushed a commit that referenced this pull request Oct 3, 2025
@rsanchez15 @richiware
Remove deprecated windows-2019 runner (#243)
d89809b 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

# Conflicts:
#	.github/workflows/nightly-windows-ci.yml
#	.github/workflows/weekly-windows-ci.yml
#	.github/workflows/windows-ci.yml
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware pushed a commit that referenced this pull request Oct 3, 2025
@rsanchez15 @richiware
Remove deprecated windows-2019 runner (#243)
a26d57a 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware pushed a commit that referenced this pull request Oct 3, 2025
@rsanchez15 @richiware
Remove deprecated windows-2019 runner (#243)
bc9e42a 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware pushed a commit that referenced this pull request Oct 3, 2025
@rsanchez15 @richiware
Remove deprecated windows-2019 runner (#243)
0387755 
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiprosima richiprosima Awaiting requested review from richiprosima

1 more reviewer

@Mario-DL Mario-DL Mario-DL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@rsanchez15 @Mario-DL