Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 27, 2025

Description

This PR updates the Windows GitHub Action Runner from windows-2019 to windows-2022. As Visual Studio 2017 build tools (v141) are no longer installed in this new runner, the PR upgrades also to toolsets to use, moving from v141 (VS2017) and v142 (VS2019) to v142 (VS2019) and v143 (VS2022).

@Mergifyio backport 2.2.x 1.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #243 done by [Mergify](https://mergify.com).

@mergify
Copy link
Author

mergify bot commented Jun 27, 2025

Cherry-pick of 19115c5 has failed:

On branch mergify/bp/1.4.x/pr-243
Your branch is up to date with 'origin/1.4.x'.

You are currently cherry-picking commit 19115c5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/reusable-windows-ci.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/nightly-windows-ci.yml
	deleted by us:   .github/workflows/weekly-windows-ci.yml
	both modified:   .github/workflows/windows-ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 27, 2025
@MiguelCompany MiguelCompany added this to the v1.4.4 milestone Jul 10, 2025
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-243 branch from 7018190 to d89809b Compare October 3, 2025 10:12
@richiware richiware added ci-pending PR which CI is running and removed conflicts labels Oct 3, 2025
@richiware richiware self-requested a review October 3, 2025 10:12
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-243 branch from d89809b to a26d57a Compare October 3, 2025 10:14
@richiware richiware requested review from richiware and removed request for richiware October 3, 2025 10:14
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-243 branch from a26d57a to bc9e42a Compare October 3, 2025 10:18
@richiware richiware requested review from richiware and removed request for richiware October 3, 2025 10:19
* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add matrix to windows-ci

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 19115c5)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-243 branch from bc9e42a to 0387755 Compare October 3, 2025 10:28
@richiware richiware merged commit 7b7a574 into 1.4.x Oct 3, 2025
8 checks passed
@richiware richiware deleted the mergify/bp/1.4.x/pr-243 branch October 3, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants