[23754] Remove compilation warning with InstanceHandle_t #262

richiware · 2025-10-02T10:36:10Z

Description

Remove compilation warning with InstanceHandle_t. Also this PR fixes some swig warnings.

@Mergifyio backport 2.3.x 2.2.x 1.4.x

Contributor Checklist

Commit messages follow the project guidelines.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Changes are API compatible.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

fastdds_python/src/swig/fastdds/rtps/common/InstanceHandle.i

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

fastdds_python/src/swig/fastdds/rtps/common/InstanceHandle.i

MiguelCompany

LGTM with green CI

MiguelCompany · 2025-10-03T07:38:41Z

@Mergifyio backport 2.3.x 2.2.x 1.4.x

mergify · 2025-10-03T07:38:49Z

backport 2.3.x 2.2.x 1.4.x

✅ Backports have been created

Details

#263 [23754] Remove compilation warning with InstanceHandle_t (backport #262) has been created for branch 2.3.x but encountered conflicts
#264 [23754] Remove compilation warning with InstanceHandle_t (backport #262) has been created for branch 2.2.x but encountered conflicts
#265 [23754] Remove compilation warning with InstanceHandle_t (backport #262) has been created for branch 1.4.x but encountered conflicts

* Refs #23753. Take into account dependencies for rebuild Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Fix warning Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Remove swig warnings Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Add unit tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 6ee4ca5) # Conflicts: # fastdds_python/src/swig/fastdds/rtps/common/BinaryProperty.i # fastdds_python/src/swig/fastdds/rtps/common/Locator.i # fastdds_python/src/swig/fastdds/rtps/common/Property.i

* Refs #23753. Take into account dependencies for rebuild Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Fix warning Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Remove swig warnings Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Add unit tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 6ee4ca5) # Conflicts: # fastdds_python/src/swig/fastdds/dds/core/Time_t.i # fastdds_python/src/swig/fastdds/rtps/common/BinaryProperty.i # fastdds_python/src/swig/fastdds/rtps/common/InstanceHandle.i # fastdds_python/src/swig/fastdds/rtps/common/Locator.i # fastdds_python/src/swig/fastdds/rtps/common/Property.i # fastdds_python/test/CMakeLists.txt

* Refs #23753. Take into account dependencies for rebuild Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Fix warning Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Remove swig warnings Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Add unit tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23753. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 6ee4ca5)

richiware added 3 commits October 2, 2025 10:52

Refs #23753. Take into account dependencies for rebuild

f34ffca

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #23753. Fix warning

e7c88e0

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #23753. Remove swig warnings

d179b4b

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware changed the title ~~Remove compilation warning with InstanceHandle_t~~ [23754] Remove compilation warning with InstanceHandle_t Oct 2, 2025

Refs #23753. Add unit tests

10bfb67

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the bugfix/23753 branch from f9e26e4 to 10bfb67 Compare October 2, 2025 10:45

MiguelCompany self-requested a review October 2, 2025 10:49

github-actions bot added the ci-pending PR which CI is running label Oct 2, 2025

MiguelCompany requested changes Oct 2, 2025

View reviewed changes

richiware requested a review from MiguelCompany October 2, 2025 12:32

Refs #23753. Apply suggestions

698b7b2

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the bugfix/23753 branch from 57a4f12 to 698b7b2 Compare October 3, 2025 06:01

richiware requested review from MiguelCompany and removed request for MiguelCompany October 3, 2025 06:03

MiguelCompany added this to the v2.4.0 milestone Oct 3, 2025

MiguelCompany requested changes Oct 3, 2025

View reviewed changes

fastdds_python/src/swig/fastdds/rtps/common/InstanceHandle.i Show resolved Hide resolved

MiguelCompany self-requested a review October 3, 2025 07:37

MiguelCompany approved these changes Oct 3, 2025

View reviewed changes

richiware merged commit 6ee4ca5 into main Oct 3, 2025
14 checks passed

richiware deleted the bugfix/23753 branch October 3, 2025 08:10

This was referenced Oct 3, 2025

[23754] Remove compilation warning with InstanceHandle_t (backport #262) #263

Merged

[23754] Remove compilation warning with InstanceHandle_t (backport #262) #264

Merged

[23754] Remove compilation warning with InstanceHandle_t (backport #262) #265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23754] Remove compilation warning with InstanceHandle_t #262

[23754] Remove compilation warning with InstanceHandle_t #262

Uh oh!

richiware commented Oct 2, 2025 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany left a comment

Uh oh!

MiguelCompany commented Oct 3, 2025

Uh oh!

mergify bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[23754] Remove compilation warning with InstanceHandle_t #262

[23754] Remove compilation warning with InstanceHandle_t #262

Uh oh!

Conversation

richiware commented Oct 2, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

MiguelCompany commented Oct 3, 2025

Uh oh!

mergify bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richiware commented Oct 2, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Oct 3, 2025 •

edited

Loading