Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Oct 3, 2025

Description

Remove compilation warning with InstanceHandle_t. Also this PR fixes some swig warnings.

@Mergifyio backport 2.3.x 2.2.x 1.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #262 done by [Mergify](https://mergify.com).

@mergify
Copy link
Author

mergify bot commented Oct 3, 2025

Cherry-pick of 6ee4ca5 has failed:

On branch mergify/bp/1.4.x/pr-262
Your branch is up to date with 'origin/1.4.x'.

You are currently cherry-picking commit 6ee4ca5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fastdds_python/src/swig/CMakeLists.txt
	new file:   fastdds_python/test/unittest/dds/common/test_InstanceHandle.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fastdds_python/src/swig/fastdds/dds/core/Time_t.i
	both modified:   fastdds_python/src/swig/fastdds/rtps/common/BinaryProperty.i
	both modified:   fastdds_python/src/swig/fastdds/rtps/common/InstanceHandle.i
	both modified:   fastdds_python/src/swig/fastdds/rtps/common/Locator.i
	both modified:   fastdds_python/src/swig/fastdds/rtps/common/Property.i
	both modified:   fastdds_python/test/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 3, 2025
@MiguelCompany MiguelCompany added this to the v1.4.4 milestone Oct 3, 2025
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from 6142b39 to 45155d8 Compare October 3, 2025 09:54
@richiware richiware added ci-pending PR which CI is running and removed conflicts labels Oct 3, 2025
@richiware richiware self-requested a review October 3, 2025 09:54
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from 45155d8 to aff976d Compare October 3, 2025 09:56
@richiware richiware requested review from richiware and removed request for richiware October 3, 2025 09:56
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from aff976d to ab67dd6 Compare October 3, 2025 11:01
@richiware richiware self-requested a review October 3, 2025 11:02
richiware
richiware previously approved these changes Oct 3, 2025
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from ab67dd6 to 3565df0 Compare October 6, 2025 05:53
@richiware richiware self-requested a review October 6, 2025 05:59
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from 3565df0 to 72337ae Compare October 6, 2025 07:40
@richiware richiware requested review from richiware and removed request for richiware October 6, 2025 07:40
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from 72337ae to b158e20 Compare October 6, 2025 08:15
@richiware richiware requested review from richiware and removed request for richiware October 6, 2025 08:16
* Refs #23753. Take into account dependencies for rebuild

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #23753. Fix warning

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #23753. Remove swig warnings

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #23753. Add unit tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #23753. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 6ee4ca5)
@richiware richiware force-pushed the mergify/bp/1.4.x/pr-262 branch from b158e20 to 1c84a8f Compare October 6, 2025 08:40
@richiware richiware requested review from richiware and removed request for richiware October 6, 2025 08:40
@richiware richiware merged commit f54bc8f into 1.4.x Oct 6, 2025
8 checks passed
@richiware richiware deleted the mergify/bp/1.4.x/pr-262 branch October 6, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants