Wrong SWT Error in Image(Device, InputStream) for IOException #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per contract of org.eclipse.swt.graphics.Image.Image(Device, InputStream), SWT Error - ERROR_IO should be thrown if IOException is caught while reading the inputStream.
ShahzaibIbrahim
force-pushed
the
master-584
branch
from
22b88f9 to
1a31db5
Compare
Contributor
HeikoKlare
approved these changes
Jan 13, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
This obviously adapts the implementation to the existing contract. Great to also see a test for the behavior.
It seems like the behavior used to be correct but was accidentally modified for Cocoa with:
This change corrects that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per contract of org.eclipse.swt.graphics.Image.Image(Device, InputStream), SWT Error - ERROR_IO should be thrown if IOException is caught while reading the inputStream.