Skip to content

Wrong SWT Error in Image(Device, InputStream) for IOException #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Jan 13, 2026
Merged

Wrong SWT Error in Image(Device, InputStream) for IOException #2960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ public Image(Device device, InputStream stream) {
zoom -> ImageDataLoader.loadByZoom(new ByteArrayInputStream(input), FileFormat.DEFAULT_ZOOM, zoom).element());
init();
} catch (IOException e) {
SWT.error(SWT.ERROR_INVALID_ARGUMENT, e);
SWT.error(SWT.ERROR_IO, e);
} finally {
if (pool != null) pool.release();
}
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,7 +2247,7 @@ private class ImageDataLoaderStreamProviderWrapper extends ImageFromImageDataPro
this.inputStreamData = inputStream.readAllBytes();
initImage();
} catch (IOException e) {
SWT.error(SWT.ERROR_INVALID_ARGUMENT, e);
SWT.error(SWT.ERROR_IO, e);
}
}

Expand Down
9 changes: 9 additions & 0 deletions ...wt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,15 @@ public void test_ConstructorLorg_eclipse_swt_graphics_DeviceLjava_io_InputStream
}
assertSWTProblem("Incorrect exception thrown for invalid InputStream", SWT.ERROR_UNSUPPORTED_FORMAT, e);

InputStream failingStream = new InputStream() {
@Override
public int read() throws IOException {
throw new IOException("bad input stream");
}
};
e = assertThrows(SWTException.class, () -> new Image(display, failingStream));
assertSWTProblem("Incorrect exception thrown for invalid InputStream", SWT.ERROR_IO, e);

String firstFile = SwtTestUtil.invalidImageFilenames[0];
Display[] displays = { display, null };
for (Display display : displays) {
Expand Down
Loading