Skip to content

Conversation

@tivervac
Copy link
Contributor

@tivervac tivervac commented Feb 6, 2025

@vogella Sorry for the delay. This PR is the followup for eclipse-platform/eclipse.platform.swt#1634

I can remove the cleanup if required, I'm mostly interested in the new pages.

@vogella
Copy link
Contributor

vogella commented Feb 6, 2025

@tivervac Thanks. From a quick gance the change looks good. I assume lots of this information needs updates based on work @HeikoKlare (Edge) and @HannesWell (GTK) are doing but that could be done IMHO in another PR.

I have a close look next week and will merge it if I do not find issues.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Results

 1 599 files  +1   1 599 suites  +1   1h 25m 53s ⏱️ - 1m 4s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
12 001 runs  +3  11 835 ✅ +3  166 💤 ±0  0 ❌ ±0 

Results for commit d10ae88. ± Comparison against base commit 661c9f5.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor

I've made a note to myself to take a look at and update the FAQ related to Edge soon. They also look rather outdated to me.

@tivervac
Copy link
Contributor Author

@vogella the single CI failure doesn't seem to be because of my changes. Do these look good or should we wait for Heiko?

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you the implicit reminder 🙂 I have just prepared an adaptation of the Edge FAQ. I would propose to keep this PR as is and make everything else (including my proposal) as a follow-up change. What do you think?

Just two thoughts regarding this PR:

  • When making my changes, I have been searching some time for the document, because most files are named FAQ_* while some of the new files are named FAQ-*. It's rather nitpicky, but should/could we align the names to have them properly ordered?
  • Some of the new FAQ pages are missing a headline (exactly the ones having a differently formatted file name). Should we add a headline to them?

@tivervac
Copy link
Contributor Author

Yes, that makes sense. Done.

@HeikoKlare
Copy link
Contributor

Great, thank you for the quick reply! I would be in favor of merging your changes then to finally have them in. In case there is need for adaptation, we can still make follow-up changes.
Could you squash your commits and rebase on master?

@tivervac tivervac force-pushed the master branch 3 times, most recently from ea6e3c4 to 821c368 Compare March 26, 2025 16:00
* Cleanup fenced code blocks
* Some small markdown cleanup
@HeikoKlare HeikoKlare merged commit eca8380 into eclipse-platform:master Mar 30, 2025
17 of 18 checks passed
@vogella
Copy link
Contributor

vogella commented Mar 31, 2025

Thanks @HeikoKlare and @tivervac for handling this one. I lost track of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants