Skip to content

Conversation

@basilevs
Copy link
Contributor

@basilevs basilevs commented Dec 30, 2025

Job.cancel() is not synchronized with job's state, so cancelling a running job produces an undefined getResult().
Avoid job.cancel() when getResult() is needed.

Fixes #2339

@github-actions
Copy link
Contributor

Test Results

 1 953 files  ±0   1 953 suites  ±0   1h 23m 44s ⏱️ - 13m 39s
 4 745 tests ±0   4 721 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 235 runs  ±0  14 053 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit 8a72997. ± Comparison against base commit 53950e7.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look into this so quickly, @basilevs!
The proposal looks sound to me. Let's give it a try.

@HeikoKlare HeikoKlare merged commit 3b0c3f3 into eclipse-platform:master Dec 30, 2025
18 checks passed
@basilevs basilevs deleted the cancelFlag_2339 branch December 30, 2025 15:14
@basilevs
Copy link
Contributor Author

Thank you for taking a look into this so quickly, @basilevs! The proposal looks sound to me. Let's give it a try.

The whole test looks like a big Job framework workaround. I should've followed @jukzi advice and used a filesystem mock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IFileTest#testIssue2290() fails sporadically in GHA runs

2 participants