Skip to content

Job.cancel() makes Job.getResult() unstable, remove it #2339 #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Dec 30, 2025
Merged

Job.cancel() makes Job.getResult() unstable, remove it #2339 #2343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ...lipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/IFileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.io.OutputStream;
import java.util.concurrent.BrokenBarrierException;
import java.util.concurrent.CyclicBarrier;
import java.util.concurrent.atomic.AtomicBoolean;
import org.eclipse.core.resources.IFile;
import org.eclipse.core.resources.IFolder;
import org.eclipse.core.resources.IProject;
Expand Down Expand Up @@ -142,14 +143,17 @@ public void testIssue2290() throws CoreException, InterruptedException, BrokenBa
IProject project = getWorkspace().getRoot().getProject("MyProject");
IFile subject = project.getFile("subject.txt");
CyclicBarrier jobStart = new CyclicBarrier(2);
Job createDelete = Job.create("Create/delete", monitor -> {
// Can't use `Job.cancel()`, it makes `getResult()` unstable.
// https://github.com/eclipse-platform/eclipse.platform/issues/2339
AtomicBoolean keepRunning = new AtomicBoolean(true);
Job createDelete = Job.create("Create/delete", ignored -> {
try {
jobStart.await();
while (!monitor.isCanceled()) {
while (keepRunning.get()) {
createInWorkspace(subject);
while (!monitor.isCanceled()) {
while (keepRunning.get()) {
try {
subject.delete(true, monitor);
subject.delete(true, null);
break;
} catch (CoreException e) {
// On Windows, files opened for reading can't be deleted, try again
Expand All @@ -176,10 +180,12 @@ public void testIssue2290() throws CoreException, InterruptedException, BrokenBa
jobStart.await();
long stop = currentTimeMillis() + 1000;
while (currentTimeMillis() < stop) {
assertContentAccessibleOrNotFound(subject); // should not throw
// should not throw
// https://github.com/eclipse-platform/eclipse.platform/issues/2290
assertContentAccessibleOrNotFound(subject);
}
} finally {
createDelete.cancel();
keepRunning.set(false);
createDelete.join();
IStatus result = createDelete.getResult();
if (!result.isOK()) {
Expand Down
Loading