[test] Use inline cflags argument where is makes sense. NFC #26178
Conversation
sbc100
changed the title
There are several ways to add cflags when running tests. In cases where the number of flags is small and used only once it makes sense to just inline them into the call to `do_runf` (or one of the other test helpers).
|
Good to go now? |
|
Sorry, this is a long one, and I was just around 50% done... now I see I am hitting the rebase problem. There is just one commit, and clicking "compare" on your force-push only shows the entire diff, not just your last changes, which includes all the code I've already reviewed... any suggestions for how to read this? |
|
I re-uploaded this PR again, this time keeping the original change and adding to it. (Sadly I did have to force push again, but at least you can see that I just made a one line change based on top of the original one). |
|
Thanks! Ok, I still have half the original commit to go, but I'm making progress now. |
| self.do_runf('core/test_asyncify_lists.cpp', ('RuntimeError', 'Thrown at'), assert_returncode=NON_ZERO) | ||
|
|
||
| # use of ASYNCIFY_* options may require intermediate debug info. that should | ||
| # not end up emitted in the final binary |
There was a problem hiding this comment.
Odd our linters didn't catch the pre-existing indentation issue?
There was a problem hiding this comment.
Yes, I think our linter does not actually check for indentation right now!
…en-core#26178) There are several ways to add cflags when running tests. In cases where the number of flags is small and used only once it makes sense to just inline them into the call to `do_runf` (or one of the other test helpers).
2 participants
There are several ways to add cflags when running tests. In cases where the number of flags is small and used only once it makes sense to just inline them into the call to
do_runf(or one of the other test helpers).