Conversation
Contributor
|
@ZhipengXue97 thank you! |
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Type hints Fix * style: sort/ruff files * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit 47603b8)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Type hints Fix * style: sort/ruff files * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit 47603b8)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Type hints Fix * style: sort/ruff files * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit 47603b8)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Type hints Fix * style: sort/ruff files * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit 47603b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix type check warning reported by Pyre@Google, which was outdated after code modification.
Detail
update the return type of function
_read_dict()fromdicttoMapping, since the condition check of the returnnew_dictand typeMappingafter commit 9193b1f