Skip to content

Type hints Fix #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sijis merged 3 commits into from
May 21, 2025
Merged

Type hints Fix #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bf1695
Type hints Fix
ZhipengXue97 Jul 10, 2024
2d7ba20
style: sort/ruff files
sijis May 21, 2025
0111148
docs: add info to CHANGES
sijis May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fixes:
- chore: bump jinja2 to 3.1.6 (#1723)
- chore: update errbot-backend-slackv3 version to 0.3.1 (#1725)
- fix: Close and join thread pools between tests (#1724)
- fix: type hints (#1698)


v6.2.0 (2024-01-01)
Expand Down
7 changes: 3 additions & 4 deletions errbot/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import logging
import os
import sys
from collections.abc import Mapping
from os import W_OK, access, getcwd, path, sep
from pathlib import Path
from platform import system
Expand Down Expand Up @@ -64,7 +65,7 @@ def get_config(config_path: str):
log.error(f"I cannot find the config file {config_path}.")
log.error("You can change this path with the -c parameter see --help")
log.info(
f'You can use the template {os.path.realpath(os.path.join(__file__, os.pardir, "config-template.py"))}'
f"You can use the template {os.path.realpath(os.path.join(__file__, os.pardir, 'config-template.py'))}"
f" as a base and copy it to {config_path}."
)
log.info("You can then customize it.")
Expand All @@ -81,9 +82,7 @@ def get_config(config_path: str):
exit(-1)


def _read_dict() -> dict:
from collections.abc import Mapping

def _read_dict() -> Mapping:
new_dict = ast.literal_eval(sys.stdin.read())
if not isinstance(new_dict, Mapping):
raise ValueError(
Expand Down