Disable warmups during pystats #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that no warmup iterations run when collecting pystats in the benchmark script and documents that change.
- Added a flag to disable warmups for pystats runs.
- Updated the changelog with the new behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bench_runner/scripts/run_benchmarks.py | Added --warmups 0 to extra_args to disable warmup iterations. |
| CHANGELOG.md | Documented the “No warmups on pystats runs” change under Bugfixes. |
Comments suppressed due to low confidence (1)
CHANGELOG.md:7
- [nitpick] The phrasing is a bit awkward; consider rewording to something like: "To avoid missing statistics during warmup runs, warmups are disabled when collecting pystats."
To prevent "missing" some stats collected during warmup runs, they are now
| os.environ[LOOPS_FILE_ENV_VAR] = "loops.json" | ||
|
|
||
| extra_args = ["--hook", "pystats"] | ||
| extra_args = ["--hook", "pystats", "--warmups", "0"] |
There was a problem hiding this comment.
[nitpick] The literal "0" here is a magic value; consider defining a named constant (e.g., WARMUPS_DISABLED) or using a configuration variable for clarity and easier updates.
Suggested change
| extra_args = ["--hook", "pystats", "--warmups", "0"] | |
| extra_args = ["--hook", "pystats", "--warmups", WARMUPS_DISABLED] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.