Skip to content

Disable warmups during pystats #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 1 commit into from
Jun 20, 2025
Merged

Disable warmups during pystats #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

### Bugfixes

#### No warmups on pystats runs

To prevent "missing" some stats collected during warmup runs, they are now
disabled when collecting pystats.

#### Removing a git repo on Windows fails

One needs to remove the "read only" flags on certain files in the git repo in order to remove it.
Expand Down
2 changes: 1 addition & 1 deletion bench_runner/scripts/run_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def collect_pystats(
if LOOPS_FILE_ENV_VAR not in os.environ:
os.environ[LOOPS_FILE_ENV_VAR] = "loops.json"

extra_args = ["--hook", "pystats"]
extra_args = ["--hook", "pystats", "--warmups", "0"]
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The literal "0" here is a magic value; consider defining a named constant (e.g., WARMUPS_DISABLED) or using a configuration variable for clarity and easier updates.

Suggested change
extra_args = ["--hook", "pystats", "--warmups", "0"]
extra_args = ["--hook", "pystats", "--warmups", WARMUPS_DISABLED]

Copilot uses AI. Check for mistakes.

if flags is None:
flags = []
Expand Down
Loading