Skip to content

Comments

Added result model for ForceOutput#1752

Merged
piotrkluba merged 5 commits intorelease-candidate/25.8from
piotr/add-force-output-results
Feb 4, 2026
Merged

Added result model for ForceOutput#1752
piotrkluba merged 5 commits intorelease-candidate/25.8from
piotr/add-force-output-results

Conversation

@piotrkluba
Copy link
Collaborator

@piotrkluba piotrkluba commented Jan 28, 2026

Note

Medium Risk
Introduces new results discovery/downloading paths based on file-list pattern matching and extends the results.download(all=True) gating logic, which could affect what files get downloaded for SimulationParams-based cases.

Overview
Adds first-class support for downloading and reading ForceOutput result CSVs via a new CustomForceResultModel, which discovers per-output files using the force_output_(.+)_v2.csv pattern and exposes name-based access ([]/get_custom_force_by_name) and bulk download.

Wires custom_forces into CaseResultsModel (including download(custom_forces=...) and all=True gating via Case.has_custom_forces() / SimulationParams.has_custom_forces()), and refactors monitor/UDD discovery into _populate_* helpers with tests for idempotency and download-method propagation. Test fixtures are expanded with mock API file listings and sample force-output CSVs plus comprehensive unit tests for discovery, access, download wiring, and CSV loading.

Written by Cursor Bugbot for commit 08f80a9. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@piotrkluba piotrkluba enabled auto-merge (squash) February 4, 2026 14:45
@piotrkluba piotrkluba merged commit 15ce160 into release-candidate/25.8 Feb 4, 2026
19 checks passed
@piotrkluba piotrkluba deleted the piotr/add-force-output-results branch February 4, 2026 14:47
github-actions bot pushed a commit that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants