Skip to content

Conversation

@kmehant
Copy link
Collaborator

@kmehant kmehant commented Apr 29, 2025

Incorrect check leading to unnecessary lora checks to non fast moe runs. Introduced in #530

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

dushyantbehl
dushyantbehl previously approved these changes Apr 29, 2025
Copy link
Collaborator

@dushyantbehl dushyantbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
Copy link
Collaborator

@dushyantbehl dushyantbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dushyantbehl dushyantbehl merged commit f2ba2c3 into foundation-model-stack:main Apr 29, 2025
9 checks passed
dushyantbehl pushed a commit to dushyantbehl/fms-hf-tuning that referenced this pull request Jun 23, 2025
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants