Skip to content

fix: incorrect check on fast moe activation #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dushyantbehl merged 1 commit into from
Apr 29, 2025
Merged

fix: incorrect check on fast moe activation #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tuning/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ def train(
"`--padding_free` argument was called with `packing=True`, "
"Trainer should not perform packing when using `--padding_free`"
)

if fast_moe_config is not None and fast_moe_config.fast_moe is None:
fast_moe_config = None
if fast_moe_config is not None:
# Checking for unsupported modules with Scatter MoE for LoRA
# Only raise an error for `all-linear`
Expand Down