Skip to content

fix: correct if_then and switch_expression type inference calls #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giospada wants to merge 3 commits into from
Closed

fix: correct if_then and switch_expression type inference calls #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce10eb
Merge branch 'main' into temp_contribution
giospada Dec 1, 2025
226a170
fix: if_then and switch_expresion calling o infer_expression_type
giospada Nov 21, 2025
3e8c3c0
feat: update proto codegen and add typing_extension dependency
giospada Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = [{name = "Substrait contributors", email = "substrait@googlegroups.com
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.10"
dependencies = ["protobuf >=3.19.1,<6"]
dependencies = ["protobuf >=3.19.1,<6", "typing_extensions"]
dynamic = ["version"]

[tool.setuptools_scm]
Expand Down
26 changes: 14 additions & 12 deletions src/substrait/gen/json/simple_extensions.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/substrait/type_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,11 @@ def infer_expression_type(
elif rex_type == "window_function":
return expression.window_function.output_type
elif rex_type == "if_then":
return infer_expression_type(expression.if_then.ifs[0].then)
return infer_expression_type(expression.if_then.ifs[0].then, parent_schema)
elif rex_type == "switch_expression":
return infer_expression_type(expression.switch_expression.ifs[0].then)
return infer_expression_type(
expression.switch_expression.ifs[0].then, parent_schema
)
elif rex_type == "cast":
return expression.cast.type
elif rex_type == "singular_or_list" or rex_type == "multi_or_list":
Expand Down
Loading