Rust: Tweaks and improvements to data flow barriers#20921
Merged
paldepind merged 4 commits intogithub:mainfrom Nov 27, 2025
Merged
Rust: Tweaks and improvements to data flow barriers#20921paldepind merged 4 commits intogithub:mainfrom
paldepind merged 4 commits intogithub:mainfrom
Conversation
e391cc2 to
815af34
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors data flow barriers to improve specificity and reduce false positives in security queries. The main changes split combined barriers into separate, more specific ones, and add a new barrier type for fieldless enums.
- Refactors
IntegralOrBooleanTypeBarrierinto separateIntegralTypeBarrierandBooleanTypeBarrierclasses for better granularity - Introduces a new
FieldlessEnumTypeBarrierto filter out fieldless enum types that are typically not interesting to track - Applies these barriers to security queries (SQL injection, log injection, cleartext logging, and regex injection) to reduce false positives
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/security/Barriers.qll | Splits combined barriers into separate classes, adds FieldlessEnumTypeBarrier, and improves comment clarity |
| rust/ql/lib/codeql/rust/internal/Type.qll | Adds getEnum() accessor method to EnumType for consistency with other type classes |
| rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll | Updates to use separate IntegralTypeBarrier and BooleanTypeBarrier |
| rust/ql/lib/codeql/rust/security/SqlInjectionExtensions.qll | Adds BooleanTypeBarrier and FieldlessEnumTypeBarrier |
| rust/ql/lib/codeql/rust/security/LogInjectionExtensions.qll | Adds BooleanTypeBarrier and FieldlessEnumTypeBarrier |
| rust/ql/lib/codeql/rust/security/CleartextLoggingExtensions.qll | Adds Barriers import, BooleanTypeBarrier, and FieldlessEnumTypeBarrier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hvitved
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.